Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backup schedule contains an invalid schedule #5400

Merged
merged 6 commits into from
Oct 12, 2023

Conversation

fengluodb
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Oct 11, 2023
@fengluodb fengluodb force-pushed the bugfix/backup-schedule-contains-invalid-schedule branch from 79bd094 to 0c2d813 Compare October 11, 2023 11:18
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (89ec847) 68.82% compared to head (ca56241) 68.89%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5400      +/-   ##
==========================================
+ Coverage   68.82%   68.89%   +0.07%     
==========================================
  Files         261      261              
  Lines       29674    29674              
==========================================
+ Hits        20422    20445      +23     
+ Misses       7614     7602      -12     
+ Partials     1638     1627      -11     
Flag Coverage Δ
unittests 68.89% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/user_docs/cli/kbcli_cluster_create.md Outdated Show resolved Hide resolved
internal/cli/cmd/cluster/create.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Oct 12, 2023
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Oct 12, 2023
@fengluodb fengluodb force-pushed the bugfix/backup-schedule-contains-invalid-schedule branch 2 times, most recently from 8732026 to ae32ceb Compare October 12, 2023 03:42
@fengluodb fengluodb force-pushed the bugfix/backup-schedule-contains-invalid-schedule branch from ae32ceb to ca4d1a3 Compare October 12, 2023 04:20
@fengluodb fengluodb force-pushed the bugfix/backup-schedule-contains-invalid-schedule branch from ca4d1a3 to eaa8a03 Compare October 12, 2023 04:29
@fengluodb fengluodb merged commit b9bb7ff into main Oct 12, 2023
102 checks passed
@fengluodb fengluodb deleted the bugfix/backup-schedule-contains-invalid-schedule branch October 12, 2023 07:00
@github-actions github-actions bot added this to the Release 0.7.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] BackupSchedule contains an invalid schedule for clusters created by kbcli
4 participants